This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Raise toolchain requirements for MXNet 2 #17984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [website, centos-cpu, edge, centos-gpu, unix-cpu, windows-cpu, sanity, windows-gpu, unix-gpu, miscellaneous, clang] Note: |
leezu
force-pushed
the
cpp17
branch
10 times, most recently
from
b8a65c5
to
29f8ed7
Compare
leezu
force-pushed
the
cpp17
branch
2 times, most recently
from
ea43436
to
6c41b7d
Compare
leezu
force-pushed
the
cpp17
branch
2 times, most recently
from
468f73b
to
8a585bf
Compare
leezu
force-pushed
the
cpp17
branch
3 times, most recently
from
0096d4c
to
0bf829a
Compare
|
Note: With this we will be able to change shared_ptr here: https://github.com/apache/incubator-mxnet/blob/master/src/engine/threaded_engine.h#L440 to |
leezu
force-pushed
the
cpp17
branch
2 times, most recently
from
e516025
to
3430b08
Compare
leezu
requested review from
aaronmarkham,
anirudh2290 and
marcoabreu
as code owners
CentOS 7 fullfills the requirements for PEP 599 manylinux-2014 and provides a C++17 toolchain.
szha
reviewed
Apr 13, 2020
| @@ -24,6 +24,9 @@ | |||
| #include <mxnet/operator_util.h> | |||
There was a problem hiding this comment.
DGL no longer depends on the contrib graph operators. I would suggest to deprecate this sampling operator and even remove it in MXNet 2.0. Please see my comment here. #16167 (comment)
szha
reviewed
Apr 13, 2020
There was a problem hiding this comment.
Thanks for the upgrade, @leezu. I went through the commits and overall the changes looks good to me. It would have been nice if we could merge the individual commits in this change, though I realize that given the state of CI it may not be possible. In this case, this is an important change that I think we should accept and fix forward if there's any issue.
szha
approved these changes
Apr 13, 2020
13 tasks
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
As per apache#17968, require C++17 compatible compiler. For cuda code, use C++14 mode introduced in Cuda 9. C++17 support for Cuda will be available in Cuda 11. Switching to C++17 requires modernizing the toolchain, which exposed a number of technical debt issues in the codebase. All blocking issues are fixed as part of this PR. See the full list below. This PR contains the following specific changes: Switch CI pipeline to use gcc7 on Ubuntu and CentOS Switch CD pipeline to CentOS 7 with https://www.softwarecollections.org/en/scls/rhscl/devtoolset-7/ This enables us to build with gcc7 C++17 compiler while keeping a relatively old glibc requirement for distribution. Simplify ARM Edge builds Switch to standard Ubuntu / Debian cross-compilation toolchain for ARMv7, ARMv8 Switch to https://toolchains.bootlin.com/ toolchain for ARMv6 (the Debian ARMv6 toolchain is for ARMv4 + ARMv5 + ARMv6, but we wish to only target ARMv6 and make use of ARMv6 features) Remove reliance on dockcross for cross compilation. Simplify Jetson build Use standard Ubuntu / Debian cross-compilation toolchain for ARMv8 Upgrade to Cuda 10 and Jetpack 4.3 Simplify build setup Simplify QEMU ARM virtualization test setup on CI Remove complex "Virtual Machine in Docker" logic and run a QEMU based Docker container instead based on arm32v7/ubuntu Fix out of bounds vector accesses in SoftmaxGradOpType MKLDNNFCBackward Fix use of non-standard rand_r function (which is not available on anymore on newer Android toolchains and shouldn't be use in any case). Fix reproducibility of RNN with Dropout Fix reproducibility of DGL Graph Sampling Operators Update tests for Android Edge build to NDK19. The previously used standalone toolchain is obsolete. Those Dockerfiles that required refactoring as part of the effort were refactored based on the following consideration Maximize the use of system dependencies provided by the distribution instead of manually installing dependencies from source or from third party vendors. This reduces the complexity of the installation process and essentially pins the dependency versions, increasing CI stability. Further, Dockerfile build speed is improved. To facilitate this, use recent distribution versions. We still ensure backwards compatibility via CentOS7 based build and test stages Minimize the number of layers in the Dockerfile. Don't have 5 different script files executed, each calling apt-get update and install, but just execute once. Speeds up the build and reduces image size. Keep each Dockerfile simple and tailored to a purpose, instead of running 20 scripts to install dependencies for every thinkable scenario, which is unmaintainable. Some more small changes: Remove outdated references to Cuda 7 and Cuda 8 in various files. Remove C++03 support in mshadow Disable broken tests NumpyBooleanAssignForwardCPU apache#17990 test_init.test_rsp_const_init apache#17988 quantized_elemwise_mul apache#18034 List of squashed commits * cpp standard * Remove leftover files of Cuda 7 and Cuda 8 support * thrust 1.9.8 for clang10 * compiler warnings * Disable broken test_init.test_rsp_const_init * Disable tests invoking NumpyBooleanAssignForwardCPU * Fix out of bounds access in SoftmaxGradOpType * Use CentOS 7 for staticbuilds CentOS 7 fullfills the requirements for PEP 599 manylinux-2014 and provides a C++17 toolchain. * Fix MKLDNNFCBackward * Update edge toolchain * Support platforms without rand_r * Cleanup random.h * Greatly simplify qemu setup * Remove unused functions in Jenkins_steps.groovy * Skip quantized_elemwise_mul due QuantizedElemwiseMulOpShape bug * Fix R package installation apache#18042 * Fix centos ccache * Fix GPU Makefile staticbuild on CentOS7 * CentOS7 NCCL * CentOS7 staticbuild fix link with libculibos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #17968, require C++17 compatible compiler.
For cuda code, use C++14 mode introduced in Cuda 9. In general there is no issue with linking together objects resulting from different standards as long as they are compiled by the same compiler.
This PR contains the following specific changes:
dockcrossfor cross compilation.arm32v7/ubunturand_rfunction (which is not available on anymore on newer Android toolchains and shouldn't be use in any case).Those Dockerfiles that required refactoring as part of the effort were refactored based on the following consideration
apt-get updateandinstall, but just execute once. Speeds up the build and reduces image size. Keep each Dockerfile simple and tailored to a purpose, instead of running 20 scripts to install dependencies for every thinkable scenario, which is unmaintainable.Some more small changes: